Skip to content

remove envvar printing from check_built() #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanho63 wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −5
Open

remove envvar printing from check_built() #2621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6618bc6
remove check-envvar-print from check_built() - r-lib/rcmdcheck#237
tanho63 Sep 21, 2025
00ff68a
update news
tanho63 Sep 21, 2025
20434b3
Move bullet to correct place
hadley Jan 21, 2026
4e54301
Revise NEWS.md for devtools updates
tanho63 Sep 17, 2026
8fb7aaf
update remotes to make work while rcmdcheck#237 is still unmerged
tanho63 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Imports:
pkgdown (>= 2.2.0),
pkgload (>= 1.5.2),
profvis (>= 0.4.0),
rcmdcheck (>= 1.4.0),
rcmdcheck (>= 1.4.0.9001),
rlang (>= 1.2.0),
roxygen2 (>= 7.3.3),
rversions (>= 3.0.0),
Expand All @@ -57,6 +57,8 @@ Suggests:
spelling (>= 2.2),
xml2
VignetteBuilder: knitr, quarto
Remotes:
r-lib/rcmdcheck#237
Config/Needs/website: tidyverse/tidytemplate
Config/testthat/edition: 3
Config/testthat/parallel: true
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# devtools (development version)

* `submit_cran()` gives a more informative error when the CRAN submission form can't be used, suggesting that the user consult <https://cran.r-project.org> to see if there's a CRAN closure (#2700).
* `check_built()` no longer prints `R_CHECK_` check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621)

# devtools 2.5.2

Expand Down
4 changes: 0 additions & 4 deletions R/check.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,6 @@ check_built <- function(
}

env_vars <- check_env_vars(cran, remote, incoming, force_suggests, env_vars)
if (!quiet) {
cli::cat_rule("Checking", col = "cyan", line = 2)
show_env_vars(env_vars)
Comment thread
tanho63 marked this conversation as resolved.
}

withr::with_envvar(env_vars, action = "replace", {
rcmdcheck::rcmdcheck(
Expand Down
Loading