Skip to content

Use the platform separator for include paths - #43

Open
OskarEichler wants to merge 1 commit into
rack:mainfrom
OskarEichler:songstats/platform-include-path-separator
Open

Use the platform separator for include paths#43
OskarEichler wants to merge 1 commit into
rack:mainfrom
OskarEichler:songstats/platform-include-path-separator

Conversation

@OskarEichler

Copy link
Copy Markdown

The -I parser hard-codes : when splitting include paths. Ruby exposes File::PATH_SEPARATOR for this purpose; on Windows the separator is ;, so a normal multi-path value remains one invalid path today.

Use the platform separator while preserving Unix behavior.

Verification:

  • deterministic option-parser model fails on 2.3.1/current and passes this branch
  • full suite: 76 runs / 194 assertions / 0 failures
  • Ruby syntax, warning-mode load, package build and diff checks pass on Ruby 4.0.6
  • combined candidate also passes 74 runs / 182 assertions on Ruby 3.2.11

No breaking behavior on platforms whose separator is :.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant