Support streams with optional endpoints - #45
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rackup::Stream.newcurrently evaluates an undefinedBufferedconstant before it can construct the stream. Supplying only an input works around that constant but then forces a writable output, so the nominally optional endpoints are not actually optional. If input is absent, the first read should report EOF; an explicitclose_readshould still make later reads raise.Make both endpoints optional, retain validation when output is present, distinguish initial EOF from explicit read closure, and make
empty?safe without output.This ports the relevant source-origin Stream corrections from socketry/protocol-http commit
2c3115e, whose Stream implementation Rackup shares.Verification:
No breaking change for supplied endpoints; invalid non-writable outputs remain rejected.