Automated Resyntax fixes - #572
Open
resyntax-ci[bot] wants to merge 14 commits into
Open
Conversation
This `map` operation can be replaced with a `for/list` loop.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
…ellipses` This `->*` contract can be rewritten using `->` with ellipses.
The `predicate/c` contract is less clear than a `->` contract and no longer improves performance.
This quasiquotation is equivalent to a simple `list` call.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
This `if`-`else` chain can be converted to a `cond` expression.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Using `cond` allows converting `let` to internal definitions, reducing nesting
This use of `string-append` can be removed by using `string-join`'s keyword arguments.
This `let` expression can be pulled up into multiple `define` expressions.
This list-constructing expression can be simplified
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 10 files.
let-to-definemap-to-forquasiquote-to-listfor/fold-result-keywordnested-if-to-condpredicate/c-migrationcond-let-to-cond-definearrow-contract-with-rest-to-arrow-contract-with-ellipsesconsing-onto-static-listand-let-to-condif-let-to-condstring-append-and-string-join-to-string-joindefine-let-to-multi-definealways-throwing-if-to-when