Repository navigation
keep browser login alive on non-callback requests - #167
Merged
Merged
Conversation
cyberphantom52
added a commit
to cyberphantom52/claude-code-proxy
that referenced
this pull request
Oct 22, 2026
A silent local connection could hold the callback listener in its five-second read timeout even when the configured login timeout was about to expire. Limit each callback read to the lesser of the remaining login window and the normal per-request cap. Exercise malformed and unrelated requests before an OAuth error on the real listener, and cover bounded silent connections. This preserves terminal state, OAuth, and token-exchange failures while ensuring probes cannot extend login timeout by the full socket read allowance. Issue: raine#167
raine
force-pushed
the
fix/codex-oauth-ignore-probe
branch
from
October 25, 2026 12:40
828985a to
9dce70a
Compare
Owner
|
Thanks for the fix. Included in v0.1.47. Codex login now keeps waiting after unrelated or malformed requests reach the callback listener, instead of exiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thing
Codex browser login exits when any non-callback request hits the localhost listener.
Reproduce
Changes
src/providers/codex/auth/browser_login.rsValidation
cargo fmt --all --check cargo test --all cargo clippy --all-targets -- -D warnings -A deprecated just check-ci