Repository navigation
Conversation
ranst91
marked this pull request as ready for review
October 27, 2026 15:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
A native approval could replay from a durable AG-UI thread snapshot after backend restart but fail to resume with
APPROVAL_RESUME_NOT_FOUND: the visible interrupt was persisted while server-owned approval authority was process-local.This PR stacks on PNI-711 / #1 at
bf82841e737aa617eb05414de4a4a68217fa5e05, usingfix/ag-ui-snapshot-reconciliationas the review base. It is a local PNI-715 candidate, not an upstream merge or release request.Description & Review Guide
AgentFrameworkAgent(..., durable_approvals=True)recovery through private snapshot continuation state. Persist server-issued lifecycle records and middleware state; restore original occurrence/provider call identities, arguments, decisions, results, and retention ages. Commit a claim before a side effect; propagate claim-write failure. Cold unfinished claims become indeterminate instead of executable again.Readiness is scoped to this cold-approval fix and its PNI-711 prerequisite. Broader parity findings retain their separate owners. GitHub CI is not green: fork review/team/label automation lacks required GitHub tokens, and no Python build/test check appears in the rollup. Passing local tests and parent acceptance are separate evidence; this is not merge or release approval.
Related Issue
PNI-715, under PNI-706. This fork draft is explicitly authorized for the campaign; upstream maintainer agreement and submission are separate. PNI-711 is the prerequisite, not competing cold-resume work.
AI Assistance
AI assistance details: implementation, regressions, source review, setup documentation, and PR description. Human campaign acceptance remains pending.
Contribution Checklist