Skip to content

fix(billing): keep the synced invoice amount up to date #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whoAbhishekSah merged 1 commit into from
Aug 28, 2026
Merged

fix(billing): keep the synced invoice amount up to date #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions billing/invoice/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,10 @@ func (s *Service) upsert(ctx context.Context, customerID string,
existingInvoice.HostedURL = stripeInvoice.HostedInvoiceURL
updateNeeded = true
}
if existingInvoice.Amount != stripeInvoice.Total {
existingInvoice.Amount = stripeInvoice.Total
updateNeeded = true
}

if updateNeeded {
if _, err := s.repository.UpdateByID(ctx, *existingInvoice); err != nil {
Expand Down
3 changes: 3 additions & 0 deletions internal/store/postgres/billing_invoice_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,9 @@ func (r BillingInvoiceRepository) UpdateByID(ctx context.Context, toUpdate invoi
if toUpdate.HostedURL != "" {
updateRecord["hosted_url"] = toUpdate.HostedURL
}
// Do not guard this with `!= 0` like the fields above: an invoice can
// be credited down to zero, and that zero must be saved.
updateRecord["amount"] = toUpdate.Amount

query, params, err := dialect.Update(TABLE_BILLING_INVOICES).Set(updateRecord).Where(goqu.Ex{
"id": toUpdate.ID,
Expand Down
Loading