Conversation
|
@nrps9909 is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 216 216
Branches 56 55 -1
=========================================
Hits 216 216 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c6a7985 to
d0adf88
Compare
|
Resolved the upstream conflict at signed/GitHub-Verified head The original integration regression still fails on base ( |
Changing
rowKeywhile retaining the sameitemsarray leaves virtual rows cached with old tagged keys becauseuseItemKeyreturns a stableuseEventfunction. This fix usesReact.useCallbackwithrowKeyas its dependency so the flattened rows and key lookups recompute when the key contract changes.Rebased onto master
58c41349e204d9d8116fd2535d0db18918118bec, preserving #67's(item, index)callback and the original array indexes. The integration regression rerenders the same array fromrowKey="id"torowKey="slug".Local validation on Node 26.10.0 / pnpm 11.21.0 / React 19.3.0:
item:1instead ofitem:first), 55 passes, 1 snapshot pass.d0adf88009bb67b66972545f8bd26727b8c74bd0: all 4 suites / 56 tests / 1 snapshot pass, including the upstream callback-index expectations.The earlier approval was on the old commit; current upstream CI and maintainer review remain separate from these local results. The PR remains open.
AI assistance disclosure: Codex helped trace the stale memo dependency, reconcile the upstream callback-index change, run base/head validation, and prepare this description. The tested source, regression, diff and commit were verified directly.