Skip to content

fix: omit inert row click handlers #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nrps9909 wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −6
Open

fix: omit inert row click handlers #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/hooks/useRowInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,16 @@ export default function useRowInfo<RecordType>(
const rowProps = onRow?.(record, recordIndex);
const onRowClick = rowProps?.onClick;

const onClick: React.MouseEventHandler<HTMLElement> = (event, ...args) => {
if (expandRowByClick && mergedExpandable) {
onTriggerExpand(record, event);
}
const onClick: React.MouseEventHandler<HTMLElement> =
onRowClick || (expandRowByClick && mergedExpandable)
? (event, ...args) => {
if (expandRowByClick && mergedExpandable) {
onTriggerExpand(record, event);
}

onRowClick?.(event, ...args);
};
onRowClick?.(event, ...args);
}
: undefined;

// ====================== RowClassName ======================
let computeRowClassName: string;
Expand Down
19 changes: 19 additions & 0 deletions tests/Table.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,25 @@ describe('Table.Basic', () => {
});

describe('onRow', () => {
it('does not attach an inert click handler by default', () => {
const rowProps = [];
const Row = props => {
rowProps.push(props);
return <tr {...props} />;
};

render(
createTable({
components: { body: { row: Row } },
}),
);

expect(rowProps).not.toHaveLength(0);
rowProps.forEach(props => {
expect(props.onClick).toBeUndefined();
});
});

it('renders onRow correctly', () => {
const onRow = (record, index) => ({
id: `row-${record.key}`,
Expand Down