Repository navigation
docs: recommend useFormState for nested components with React Compiler - #1233
Open
TiagoGranelli wants to merge 1 commit into
Open
TiagoGranelli wants to merge 1 commit into
TiagoGranelli wants to merge 1 commit into
Conversation
useForm returns a stable object, so a compiled parent memoizes
<FormProvider {...methods}> and useFormContext().formState stays stale.
The migration guide now recommends useFormState({ control }) in nested
components and destructured methods such as getFieldState.
Contributor
|
@TiagoGranelli is attempting to deploy a commit to the BEEKAI OSS Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for sage-cassata-31d224 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React Compiler section of the V8 migration guide said no configuration is needed. With a compiled parent,
<FormProvider {...methods}>is memoized becauseuseFormreturns a stable object, souseFormContext().formStatestays stale in nested components. Calls likemethods.getFieldState()on the returned object stay stale for the same reason.This updates the section to recommend
useFormState({ control })in nested components and destructured methods, as discussed in react-hook-form/react-hook-form#13863.I checked the example and the destructured
getFieldStateagainst 8.0.0-beta.4 compiled with babel-plugin-react-compiler 1.0.0 and with oxc-transform-react 0.154.0.