Skip to content

fix: normalize native storage errors without throwing #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krizzu merged 1 commit into from
Aug 31, 2026
+9 −2
Merged

fix: normalize native storage errors without throwing #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/review-errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@react-native-async-storage/async-storage": patch
---

Return existing AsyncStorageError instances, handle null rejection values safely, and classify LegacyStorageException as OtherStorageError.

5 changes: 3 additions & 2 deletions packages/async-storage/src/AsyncStorageError.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class AsyncStorageError extends Error {
static nativeError(e: unknown): AsyncStorageError {
// do not override own error
if (e instanceof AsyncStorageError) {
throw e;
return e;
}

const error = getNativeError(e);
Expand All @@ -58,6 +58,7 @@ export class AsyncStorageError extends Error {
errorType = AsyncStorageErrorType.SqliteStorageError;
break;
case "OtherException":
case "LegacyStorageException":
errorType = AsyncStorageErrorType.OtherStorageError;
break;
}
Expand All @@ -77,7 +78,7 @@ export class AsyncStorageError extends Error {

// Native module reject promises with special code
function isNativeError(e: unknown): e is PotentialNativeError {
if (typeof e !== "object") {
if (e === null || typeof e !== "object") {
return false;
}

Expand Down
Loading