Conversation
Summary: As spotted by @vzaidman in #1892 (comment) - any declaration that wraps across lines loses its indentation in `API.md` snapshots, e.g.: ```ts export type GetTransformOptions = ( entryPoints: ReadonlyArray<string>, options: GetTransformOptionsOpts, getDependenciesOf: (absoluteFilePath: string) => Promise<Array<string>>, ) => Promise<Partial<ExtraTransformOptions>>; ``` The `.d.ts` input is correctly formatted, but API Extractor's `ApiReportGenerator` writes with `trimLeadingSpaces` enabled and re-indents only between `{` and `}`, so parameter lists, type arguments and union continuations all end up flush-left (or mis-indented, when nested inside braces). There's no config option for this. This diff runs the report's code block through Prettier after cleaning, with the same options as the `.d.ts` generator (repo config, `printWidth: 200`), so declarations wrap and indent the same way they do in the published definitions. The snapshot churn is a one-off: 4-space -> 2-space indentation, `import type {X}` bracket spacing, and the indentation fixes themselves - no API changes. Changelog: Internal
meta-cla
Bot
added
the
CLA Signed
robhogan
marked this pull request as ready for review
September 16, 2026 21:51
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As spotted by @vzaidman in #1892 (comment) - any declaration that wraps across lines loses its indentation in
API.mdsnapshots, e.g.:This diff runs the report's code block through Prettier after cleaning, with the same options as the
.d.tsgenerator, so declarations wrap and indent the same way they do in the publishedd.ts.Changelog: Internal