Repository navigation
Conversation
Pre-build the 3 most recently used bundles when Metro starts serving, most recent first. A request for a bundle being pre-built joins that build instead of starting a second one, and any bundle request cancels the remaining pre-warm queue while an in-flight pre-build keeps going and serves the request. Recency is recorded only for successfully served bundle requests and persists across restarts.
Cover pre-building the 3 most recently used bundles on start, sharing an in-flight pre-build with a concurrent request, cancelling queued pre-warms on a bundle request, taking over a queued pre-warmed bundle, surviving a failed pre-warm build, and keeping recency across restarts with only successful requests updating it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-build the 3 most recently used bundles when Metro starts serving, most recent first, so the first request after a restart is served from a warm build.
Changelog: [Performance] Pre-warm the 3 most recently used bundles on server start
Test plan
Added
packages/metro/src/Server/__tests__/Server-prewarm-test.js, covering: pre-building the 3 most recent bundles on start, sharing an in-flight pre-build with a concurrent request, cancelling queued pre-warms on a bundle request, taking over a queued pre-warmed bundle, surviving a failed pre-warm build, and persisting recency across restarts with only successful requests updating it.