Remove animatedShouldUseSingleOp feature flag (#57364)#57364
Open
zeyap wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109570192. |
meta-codesync
Bot
changed the title
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Jun 30, 2026
Summary: The single-op batching guard now lives entirely in `NativeAnimatedHelper`, where `isSingleOpBatching` is gated on `Platform.OS === 'android'`, `queueAndExecuteBatchedOperations` being available, and `!cxxNativeAnimatedEnabled()`. The `animatedShouldUseSingleOp` flag defaulted to `true` and no longer carries any of that logic, so it is fully redundant. Remove the flag from the config, drop its now-vestigial term from `isSingleOpBatching` in both `NativeAnimatedHelper.js` and the macOS variant, and regenerate `ReactNativeFeatureFlags.js`. This is behavior-preserving: with the flag at its default `true`, `isSingleOpBatching` evaluates identically to before on every platform. Changelog: [Internal] Reviewed By: javache Differential Revision: D109570192
Summary: The single-op batching guard now lives entirely in `NativeAnimatedHelper`, where `isSingleOpBatching` is gated on `Platform.OS === 'android'`, `queueAndExecuteBatchedOperations` being available, and `!cxxNativeAnimatedEnabled()`. The `animatedShouldUseSingleOp` flag defaulted to `true` and no longer carries any of that logic, so it is fully redundant. Remove the flag from the config, drop its now-vestigial term from `isSingleOpBatching` in both `NativeAnimatedHelper.js` and the macOS variant, and regenerate `ReactNativeFeatureFlags.js`. This is behavior-preserving: with the flag at its default `true`, `isSingleOpBatching` evaluates identically to before on every platform. Changelog: [Internal] Reviewed By: javache Differential Revision: D109570192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The single-op batching guard now lives entirely in
NativeAnimatedHelper, whereisSingleOpBatchingis gated onPlatform.OS === 'android',queueAndExecuteBatchedOperationsbeing available, and!cxxNativeAnimatedEnabled(). TheanimatedShouldUseSingleOpflag defaulted totrueand no longer carries any of that logic, so it is fully redundant. Remove the flag from the config, drop its now-vestigial term fromisSingleOpBatchingin bothNativeAnimatedHelper.jsand the macOS variant, and regenerateReactNativeFeatureFlags.js.This is behavior-preserving: with the flag at its default
true,isSingleOpBatchingevaluates identically to before on every platform.Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D109570192