Drop boolean support for ScrollView keyboardShouldPersistTaps#57386
Open
zoontek wants to merge 2 commits into
Open
Drop boolean support for ScrollView keyboardShouldPersistTaps#57386zoontek wants to merge 2 commits into
zoontek wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
# Conflicts: # packages/react-native/Libraries/Components/ScrollView/ScrollView.js
zoontek
force-pushed
the
remove-scrollview-keyboard-should-persist-taps-bool
branch
from
e4e658f to
e27ef15
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D110218873. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes support for the deprecated boolean values of
ScrollView'skeyboardShouldPersistTapsprop.true/falsehave long been deprecated in favor of the string values'always'/'never'(with'handled'as a third option), and a runtime warning was already emitted when a boolean was passed. This drops the boolean from the type and removes the now-unused boolean handling.Migration:
keyboardShouldPersistTaps={true}→keyboardShouldPersistTaps="always"keyboardShouldPersistTaps={false}→keyboardShouldPersistTaps="never"See #57384
Changelog:
[GENERAL] [BREAKING] - Remove deprecated boolean values support for
ScrollViewkeyboardShouldPersistTapsTest Plan:
yarn flowpasses (the previously-needed$FlowFixMe[sketchy-null-bool]suppressions are gone).yarn build-typesregeneratesReactNativeApi.d.tswithkeyboardShouldPersistTaps?: "always" | "handled" | "never".never/always/handled.