fix: guard against undefined contentWindow in GiscusComments#1948
Conversation
|
@bh462007 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #1933:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary
Fixes #1933
The
GiscusCommentscomponent sends apostMessageto the giscus iframe whenevercolorModechanges. While it already checked if the iframe existed, it didn't verify that the iframe had finished loading.If
colorModechanged beforeiframe.contentWindowbecame available, callingpostMessagewould throw aTypeError.Fix
Extended the existing guard to ensure both the iframe and its
contentWindoware available before sending the message.Testing
npm run start.contentWindowwasundefined, confirming theCannot read properties of undefined (reading 'postMessage')error.