Repository navigation
[PHPUnit90] Speed up AssertRegExpRector with cheap method-name gate - #796
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perf
AssertRegExpRectorsubscribes to everySTMTS_AWAREnode and, for eachMethodCall/StaticCallstatement, callsTestsNodeAnalyzer::isPHPUnitMethodCallNames(). That helper resolves the caller type (getType()+isInstanceOfTestCase/Assert reflection) first, and only then checks the method name.So every method-call statement in a codebase pays full TestCase type resolution even when its name is not one of the four asserts the rule cares about.
Added a cheap name gate (
isNames(), pure string compare on the call name) before the type-resolving call. OnlyassertSame/assertEquals/assertNotSame/assertNotEqualscalls now reach the costly check. Behavior unchanged -isPHPUnitMethodCallNamesstill runs with the same name list right after.