Deprecate cacheClass(), select cache storage internally

config/config.php

@@ -2,9 +2,7 @@
 
 declare(strict_types=1);
 
-use OndraM\CiDetector\CiDetector;
 use Rector\Bootstrap\ExtensionConfigResolver;
-use Rector\Caching\ValueObject\Storage\MemoryCacheStorage;
 use Rector\Config\RectorConfig;
 
 return static function (RectorConfig $rectorConfig): void {
@@ -27,12 +25,6 @@
     $rectorConfig->cacheDirectory(sys_get_temp_dir() . '/rector_cached_files');
     $rectorConfig->containerCacheDirectory(sys_get_temp_dir());
 
-    // use faster in-memory cache in CI.
-    // CI always starts from scratch, therefore IO intensive caching is not worth it
-    if (new CiDetector()->isCiDetected()) {
-        $rectorConfig->cacheClass(MemoryCacheStorage::class);
-    }
-
     // load internal rector-* extension configs
     $extensionConfigResolver = new ExtensionConfigResolver();
     foreach ($extensionConfigResolver->provide() as $extensionConfigFile) {

phpstan.neon

@@ -46,7 +46,6 @@ parameters:
         - rules-tests
         - utils
         - scripts
-        - e2e/e2eTestRunnerWithCache.php
         - e2e/e2eTestRunner.php
 
     scanDirectories:

src/Caching/CacheFactory.php

@@ -4,6 +4,7 @@
 
 namespace Rector\Caching;
 
+use OndraM\CiDetector\CiDetector;
 use Rector\Caching\ValueObject\Storage\FileCacheStorage;
 use Rector\Caching\ValueObject\Storage\MemoryCacheStorage;
 use Rector\Configuration\Option;
@@ -22,24 +23,20 @@ public function __construct(
      */
     public function create(): Cache
     {
-        $cacheDirectory = SimpleParameterProvider::provideStringParameter(Option::CACHE_DIR);
-
-        $cacheClass = FileCacheStorage::class;
-
-        if (SimpleParameterProvider::hasParameter(Option::CACHE_CLASS)) {
-            $cacheClass = SimpleParameterProvider::provideStringParameter(Option::CACHE_CLASS);
+        // in CI the workspace is ephemeral and usually starts from scratch,
+        // so a file cache that is never read again is only wasted IO → use faster in-memory cache
+        if (new CiDetector()->isCiDetected()) {
+            return new Cache(new MemoryCacheStorage());
         }
 
-        if ($cacheClass === FileCacheStorage::class) {
-            // ensure cache directory exists
-            if (! $this->fileSystem->exists($cacheDirectory)) {
-                $this->fileSystem->mkdir($cacheDirectory);
-            }
+        $cacheDirectory = SimpleParameterProvider::provideStringParameter(Option::CACHE_DIR);
 
-            $fileCacheStorage = new FileCacheStorage($cacheDirectory, $this->fileSystem);
-            return new Cache($fileCacheStorage);
+        // ensure cache directory exists
+        if (! $this->fileSystem->exists($cacheDirectory)) {
+            $this->fileSystem->mkdir($cacheDirectory);
         }
 
-        return new Cache(new MemoryCacheStorage());
+        $fileCacheStorage = new FileCacheStorage($cacheDirectory, $this->fileSystem);
+        return new Cache($fileCacheStorage);
     }
 }

src/Config/RectorConfig.php

@@ -431,11 +431,14 @@ public function containerCacheDirectory(string $directoryPath): void
     /**
      * @param class-string<CacheStorageInterface> $cacheClass
      */
+    #[Deprecated(message: <<<'TXT'
+    Cache storage is selected automatically: file cache locally, in-memory cache in CI,
+     where the ephemeral workspace makes writing a cache that is never re-read wasted IO.
+     The passed value is ignored.
+    TXT)]
     public function cacheClass(string $cacheClass): void
     {
         Assert::isAOf($cacheClass, CacheStorageInterface::class);
-
-        SimpleParameterProvider::setParameter(Option::CACHE_CLASS, $cacheClass);
     }
 
     /**

src/Configuration/Option.php

@@ -4,9 +4,6 @@
 
 namespace Rector\Configuration;
 
-use Rector\Caching\Contract\ValueObject\Storage\CacheStorageInterface;
-use Rector\Caching\ValueObject\Storage\FileCacheStorage;
-
 final class Option
 {
     public const string SOURCE = 'source';
@@ -145,15 +142,6 @@ final class Option
      */
     public const string CACHE_DIR = 'cache_dir';
 
-    /**
-     * Cache backend. Most of the time we cache in files, but in ephemeral environment (e.g. CI), a faster `MemoryCacheStorage` can be useful.
-     * @internal Use RectorConfig::cacheClass() instead
-     *
-     * @var class-string<CacheStorageInterface>
-     * @internal
-     */
-    public const string CACHE_CLASS = FileCacheStorage::class;
-
     public const string DEBUG = 'debug';
 
     public const string XDEBUG = 'xdebug';