[deprecation] Deprecate DeprecatedAnnotationToDeprecatedAttributeRector and ConstAndTraitDeprecatedAttributeRector - #8347
Merged
Conversation
…or and ConstAndTraitDeprecatedAttributeRector The #[Deprecated] attribute triggers a runtime deprecation, while the @deprecated annotation is a static hint only. Those serve a different purpose and are not interchangeable, so converting one to the other is not a safe upgrade path. Use "phpstan/phpstan-deprecation-rules" to report the annotation instead. Both rules are removed from all sets, their tests and the shared DeprecatedAnnotationToDeprecatedAttributeConverter service are deleted. Pin phpVersion in the ForeachToArray* test configs, as they relied on the PHP version leaked by the removed test config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#[Deprecated]attribute triggers a runtime deprecation, while the@deprecatedannotation is a static hint only. Those have a different purpose and are not interchangeable, so converting one into the other is not a safe upgrade path - it changes application behavior at runtime.Let
phpstan/phpstan-deprecation-rulesreport the annotation instead.What the rules did
The
@deprecatedannotation stays readable in the IDE and in static analysis, without emittingE_USER_DEPRECATEDon every call.Changes
DeprecatedAnnotationToDeprecatedAttributeRectorandConstAndTraitDeprecatedAttributeRectorimplementDeprecatedInterfaceand throw onrefactor()ConstAndTraitDeprecatedAttributeRectoris dropped fromconfig/set/php85.phpDeprecatedAnnotationToDeprecatedAttributeConverterservice are deletedSide fix
The
ForeachToArray*Rectortest configs did not pinphpVersion(), and relied on the PHP version leaked by the removed test config that ran right before them. They now pinPhpVersion::PHP_84explicitly.