[CodeQuality] Skip constant expression in repeated compare to in_array rules

rules-tests/CodeQuality/Rector/BooleanAnd/RepeatedAndNotEqualToNotInArrayRector/Fixture/skip_constant_expression.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\BooleanAnd\RepeatedAndNotEqualToNotInArrayRector\Fixture;
+
+const ENVIRONMENT = 'local';
+
+final class SkipConstantExpression
+{
+    public static bool $isEnv = (ENVIRONMENT !== 'local' && ENVIRONMENT !== 'dev' && ENVIRONMENT !== 'stage');
+
+    public const IS_ENV = (ENVIRONMENT !== 'local' && ENVIRONMENT !== 'dev' && ENVIRONMENT !== 'stage');
+
+    public function demo(bool $value = (ENVIRONMENT !== 'local' && ENVIRONMENT !== 'dev' && ENVIRONMENT !== 'stage')): void
+    {
+    }
+}

rules-tests/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector/Fixture/skip_constant_expression.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\BooleanOr\RepeatedOrEqualToInArrayRector\Fixture;
+
+const ENVIRONMENT = 'local';
+
+final class SkipConstantExpression
+{
+    public static bool $isEnv = (ENVIRONMENT === 'local' || ENVIRONMENT === 'dev' || ENVIRONMENT === 'stage');
+
+    public const IS_ENV = (ENVIRONMENT === 'local' || ENVIRONMENT === 'dev' || ENVIRONMENT === 'stage');
+
+    public function demo(bool $value = (ENVIRONMENT === 'local' || ENVIRONMENT === 'dev' || ENVIRONMENT === 'stage')): void
+    {
+    }
+}

rules/CodeQuality/Rector/BooleanAnd/RepeatedAndNotEqualToNotInArrayRector.php

@@ -16,6 +16,7 @@
 use PhpParser\Node\Name;
 use Rector\CodeQuality\NodeFactory\InArrayFromRepeatedCompareFactory;
 use Rector\CodeQuality\ValueObject\ComparedExprAndValueExpr;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
@@ -68,6 +69,11 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?BooleanNot
     {
+        // in_array() func call is not allowed in a constant expression
+        if ($this->isInConstantExpression($node)) {
+            return null;
+        }
+
         if (! $this->isNotEqualOrNotIdentical($node->right)) {
             return null;
         }
@@ -96,6 +102,19 @@ public function refactor(Node $node): ?BooleanNot
         return new BooleanNot($inArrayFuncCall);
     }
 
+    private function isInConstantExpression(BooleanAnd $booleanAnd): bool
+    {
+        if ($booleanAnd->getAttribute(AttributeKey::IS_DEFAULT_PROPERTY_VALUE) === true) {
+            return true;
+        }
+
+        if ($booleanAnd->getAttribute(AttributeKey::IS_CLASS_CONST_VALUE) === true) {
+            return true;
+        }
+
+        return $booleanAnd->getAttribute(AttributeKey::IS_PARAM_DEFAULT) === true;
+    }
+
     private function isNotEqualOrNotIdentical(Expr $expr): bool
     {
         if ($expr instanceof NotIdentical) {

rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php

@@ -15,6 +15,7 @@
 use PhpParser\Node\Name;
 use Rector\CodeQuality\NodeFactory\InArrayFromRepeatedCompareFactory;
 use Rector\CodeQuality\ValueObject\ComparedExprAndValueExpr;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
@@ -67,6 +68,11 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?FuncCall
     {
+        // in_array() func call is not allowed in a constant expression
+        if ($this->isInConstantExpression($node)) {
+            return null;
+        }
+
         if (! $this->isEqualOrIdentical($node->right)) {
             return null;
         }
@@ -102,6 +108,19 @@ public function refactor(Node $node): ?FuncCall
         return new FuncCall(new Name('in_array'), $args);
     }
 
+    private function isInConstantExpression(BooleanOr $booleanOr): bool
+    {
+        if ($booleanOr->getAttribute(AttributeKey::IS_DEFAULT_PROPERTY_VALUE) === true) {
+            return true;
+        }
+
+        if ($booleanOr->getAttribute(AttributeKey::IS_CLASS_CONST_VALUE) === true) {
+            return true;
+        }
+
+        return $booleanOr->getAttribute(AttributeKey::IS_PARAM_DEFAULT) === true;
+    }
+
     private function isEqualOrIdentical(Expr $expr): bool
     {
         if ($expr instanceof Identical) {