Repository navigation
[CodeQuality] Speed up ExplicitNullableObjectInstanceRector with cheap bail before native type resolution - #8652
Merged
Conversation
…p bail before native type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
If_/ElseIf_/Ternarybranch ofExplicitNullableObjectInstanceRectorruns throughExplicitBoolConditionResolver::resolve(), which callsgetNativeType()on the condition of every single if/ternary in the analysed code - one of the hottest node shapes there is.Most of those conditions can never be a nullable object:
BinaryOp(comparisons,&&/||,===),Instanceof_,Empty_,Isset_. This adds a cheap structural bail for those shapes before the costly native type resolution, so they skip it entirely.Same pattern already used in the sibling
BinaryOpNullableToInstanceofRector::isNeverNullableObject().Behavior is unchanged - the skipped shapes already resolved to bool/non-object native types and returned
nullanyway.