Repository navigation
[DeadCode] Speed up RemoveAlwaysTrueIfConditionRector with single node traversal - #8653
Merged
Merged
Conversation
…p bail before native type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldSkipExpr()runs on nearly everyifnode and did 6 separate subtree traversals -findInstancesOf()walks the tree once per type, so 5 node types plus a FuncCall pass meant 6 full walks before the expensivegetNativeType()check.Collapsed into a single short-circuiting
findFirst()walk that bails on the first disqualifying node. Same semantics, one traversal instead of six.Existing tests cover the behavior (29 pass).