Repository navigation
[TypeDeclaration] Speed up StrictArrayParamDimFetchRector with cheap syntactic bail before reflection - #8654
Merged
Conversation
…syntactic bail before reflection Skip the parent-class reflection guards and per-param type resolution when no untyped param is used in an array dim fetch at all. The pre-scan is a purely syntactic traversal (no getType, no reflection), so the common case of untyped params that are never dim-fetched bails out early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule fires on every
ClassMethod,Function_andClosure. After the untyped-param check it ran the parent-class reflection guards (hasParentClassMethod,isTypeGuardedClass) and then per-paramgetTypetraversal - even for the common case where an untyped param is never used in an array dim fetch.This adds a cheap syntactic pre-scan: one traversal that looks for an
ArrayDimFetchwhose var is one of the untyped params, with nogetTypeand no reflection. When nothing matches, the rule bails out before any reflection or type resolution happens.