Repository navigation
[TypeDeclaration] Speed up AddReturnTypeDeclarationRector by resolving class reflection only for static return type - #8658
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…g class reflection only for static return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of
AddReturnTypeDeclarationRector. No behavior change - all 9 fixtures pass unchanged.resolveClassReflection()was called on every configured return-type change, but its result is used only when the new type is aSimpleStaticType(to rebuild it as aStaticType). The reflection resolution is now moved inside that branch, so the common configured cases (plain object/scalar/array return types) no longer pay for it.