Repository navigation
[TypeDeclaration] Speed up ReturnTypeFrom* rules by checking return shape before class method override guard - #8659
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…hape before class method override guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 8 return-type-inference rules. No behavior change - all 100 fixtures pass unchanged.
Each rule bailed out via
ClassMethodReturnTypeOverrideGuard::shouldSkipClassMethod()before checking the cheap structural precondition that there is a single/only return with an expression. That guard is reflection-heavy: it resolves class reflection, walks parent methods and checks type-guarded/abstract/interface state.The cheap return-shape check (
findReturnsScoped()+hasOnlyReturnWithExpr(), a local AST pass that needs no scope) is now done first, so methods that cannot match never pay for the override guard.ReturnTypeFromStrictConstantReturnRectoralready followed this order - the rest are aligned to it.Rules updated:
collectStrictReturnTypes())Reordering is safe: all moved checks are side-effect-free bail conditions that must all pass to proceed.