Repository navigation
[perf] Speed up return type rules with cheap structural bail before expensive scope guard - #8660
Merged
Conversation
…il before expensive scope guard
TomasVotruba
changed the title
TomasVotruba
deleted the
tv-perf-structural-bail-before-override-guard
branch
October 15, 2026 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 5 return-type rules. No behavior change - all 29 fixtures pass unchanged.
Each rule ran a reflection-heavy guard (
ClassMethodReturnTypeOverrideGuard::shouldSkipClassMethod(), orisInsideTestCaseClass()which walks the class ancestry) before the cheap structural precondition that the method/closure could even match. The cheap AST checks are now hoisted above the expensive guard, so non-matching nodes bail without paying for it.ReturnTypeFromSymfonySerializerRector- singlereturn $serializer->deserialize(...)shape (stmt count, Return_/MethodCall, name, first-class-callable) now checked before the override guard.ReturnTypeFromReturnDirectArrayRector-hasReturnArray()before the override guard.ReturnTypeFromStrictTernaryRector- single-return andTernaryshape before the override guard.AddReturnTypeFromTryCatchTypeRector- return shape (hasOnlyReturnWithExpr()) before the override guard.ClosureReturnTypeFromAssertInstanceOfRector-hasAssertInstanceOf()before the test-case ancestry check.Reordering is safe: all moved checks are side-effect-free bail conditions that must all pass to proceed.