Repository navigation
[perf] Speed up type declaration rules with cheap structural and name guards before reflection - #8661
Merged
Conversation
… guards before reflection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 7 rules. No behavior change - all fixtures pass unchanged.
Each rule ran a reflection or ancestry call before a cheap structural or name check that can bail first:
AddVoidReturnTypeWhereNoReturnRector- theisNotFinalAndHasExceptionOnly()/isNotFinalAndEmpty()guards now check the single-statement / empty-body shape beforeisInsideFinalClass()(reflection).KnownMagicClassMethodTypeRector- name filter (the handled magic methods) now runs beforehasParentClassMethod(), so non-handled magic methods (__construct,__toString,__invoke, ...) skip the parent lookup. The now-redundant second name check is folded away.AddParamTypeDeclarationRector- a class with no parent and no interfaces has no param type to mimic, so it bails beforeisTypeGuardedClass().ReturnNeverTypeRector- the nativereturnTypecheck runs beforeisInTestClass().AddPropertyTypeDeclarationRector- property name match runs before the reflection type check in the config loop.TypedPropertyFromDocblockSetUpDefinedRector- thesetUp()method lookup runs beforeisInTestClass().AddReturnTypeDeclarationFromYieldsRector- the already-filled iterator return type check runs before the yield-node subtree walk.Reordering is safe: all moved checks are side-effect-free bail conditions that must all pass to proceed.