Repository navigation
[perf] Speed up callable param type rules by deferring type resolution until shape confirmed - #8662
Merged
Merged
Conversation
…n until shape confirmed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 3 rules. No behavior change - all fixtures pass unchanged.
Each rule resolved a type or parsed a docblock before confirming the call/param shape it needs could even match:
AddClosureParamTypeFromIterableMethodCallRector- the cheapcallUsesClosures()arg check now runs beforegetType($node->var)and the method reflection lookup, so method calls with no closure argument bail first.AddParamArrayDocblockBasedOnCallableNativeFuncCallRector- the callback-argument shape checks (arg present, arrow/closure, param count, typed params) now run beforegetNativeType($arrayArgValue), so a call whose callback is not a typed closure never resolves the array native type.AddParamTypeSplFixedArrayRector- the docblock info is now parsed lazily, only once a param is confirmed to be anSplFixedArraytype, so functions with no such param no longer parse their docblock.Reordering is safe: the moved checks are side-effect-free bail conditions, and the lazy docblock is created before its first use.