Repository navigation
[perf] Speed up type declaration rules by resolving reflection only when needed - #8663
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 4 rules. No behavior change - all fixtures pass unchanged.
Each rule did reflection or a subtree walk before a cheaper check could rule the node out:
ReturnTypeFromStrictFluentReturnRector- the inferred return type is now checked for StaticType/ObjectType beforeresolveClassReflection(), so a method that does not return self/static/this never resolves the class reflection.ReturnTypeFromStrictTypedPropertyRector- thehasOnlyReturnWithExpr()shape check now runs before the per-returnresolvePropertyReflectionFromPropertyFetch()loop.PropertyTypeFromStrictSetterGetterRector- the getter/setter type match (the rule's selective precondition) now runs before theisAssignedInConstructor()walk, so a property with no matching getter/setter skips the constructor scan.ChildDoctrineRepositoryClassTypeRector- the entity type is resolved from the@extendsdocblock, so a class with no doc comment bails beforeisObjectType().Reordering is safe: all moved checks are side-effect-free bail conditions.