Skip to content

[perf] Speed up ChangeMethodVisibilityRector with cheap method name guard before ScopeFetcher #8681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfredbez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[perf] Speed up ChangeMethodVisibilityRector with cheap method name guard before ScopeFetcher #8681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions rules/Visibility/Rector/ClassMethod/ChangeMethodVisibilityRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ final class ChangeMethodVisibilityRector extends AbstractRector implements Confi
*/
private array $methodVisibilities = [];

/**
* @var string[]
*/
private array $methodNames = [];

@TomasVotruba TomasVotruba Oct 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel comfortable adding a non-readonly property with a state.
Can you handle similar check with any other way of cache?


public function __construct(
private readonly ParentClassScopeResolver $parentClassScopeResolver,
private readonly VisibilityManipulator $visibilityManipulator,
Expand Down Expand Up @@ -94,6 +99,10 @@ public function refactor(Node $node): ?Node
return null;
}

if (! $this->isNames($node, $this->methodNames)) {
return null;
}

$scope = ScopeFetcher::fetch($node);
$parentClassName = $this->parentClassScopeResolver->resolveParentClassName($scope);
if ($parentClassName === null) {
Expand Down Expand Up @@ -125,5 +134,9 @@ public function configure(array $configuration): void
Assert::allIsAOf($configuration, ChangeMethodVisibility::class);

$this->methodVisibilities = $configuration;
$this->methodNames = array_map(
static fn (ChangeMethodVisibility $changeMethodVisibility): string => $changeMethodVisibility->getMethod(),
$configuration
);
}
}
Loading