feat: added archive and delete functionality of plans

[sabre1041]

Description

Added support for archiving and deleting Plans. Support for selecting by plan names and/or labels

Archiving Plans

mtv_plans_action: archive
mtv_plans_plan_labels:
 - infra.openshift-virtualization-migration/plan-name=test-plan
mtv_plans_plan_namespace: mtv-user2

Deleting Plans

mtv_plans_action: delete
mtv_plans_plan_labels:
 - infra.openshift-virtualization-migration/plan-name=test-plan
mtv_plans_plan_namespace: mtv-user2

Type of Change

• feat: A new feature
• fix: A bug fix
• docs: Documentation changes
• style: Formatting, missing semi colons, etc; no code change
• refactor: Refactoring production code
• test: Adding missing tests, refactoring tests; no production code change
• chore: Updating configs, etc; no production code change

[tech2734]

Review Feedback

Nice work on the archive/delete functionality — clean implementation overall. A few items:

1. PR title typo

"archieve" → "archive"

2. defaults/main.yml — description missing delete from choices

The docsible description says:

# description: Action to take. Choices include: create, archive. Defaults to create.

But argument_specs.yml correctly lists all three (create, archive, delete). The description should include delete.

3. verify_archived.yml — Archived condition check may be too loose

__mtv_plans_all_archived: >-
  {{
    __mtv_plans_verify_results |
    ansible.builtin.json_query('[?status.conditions[?type==`Archived`]]') |
    length == __mtv_plans_verify_results | length
  }}

This checks for the existence of a condition with type: Archived, but does not verify that status is True. If Forklift ever sets the condition to status: False during a transition, this would incorrectly report success. Consider:

ansible.builtin.json_query('[?status.conditions[?type==`Archived` && status==`True`]]')

4. No validation that mtv_plans_plan_namespace is provided for archive/delete

Both archive.yml and delete.yml validate that at least one of plan_name or plan_labels is provided, but do not check for plan_namespace. Since Plans are namespaced resources, an empty namespace when querying by name could return nothing or fail. When querying by labels without a namespace, k8s_info queries across all namespaces — which may be intentional but could also be a safety concern. Worth adding a namespace assertion, or at least documenting the cross-namespace behavior.

5. Inconsistent verification pattern

create.yml uses the standard Ansible until/retries/delay loop for verifying plans are ready, but verify_archived.yml and verify_deleted.yml use recursive include_tasks with a manual counter and pause. Both work, but it is an inconsistency within the same role. The recursive approach is harder to debug (stack depth, variable scoping) compared to until.

[sabre1041]

@tech2734 Updated based on your feedback. Should be good for another review

[tech2734]

All feedback addressed — condition checks now verify status==True, description includes all three choices, and the verification pattern is now consistent across create/archive/delete with the new verify_ready.yml. Nice refactor. LGTM.

[sabre1041]

closing due to ci failure