feat: Added new role for managing registry credentials

[sabre1041]

Description

Adds a new role for managing registry credentials. Enables creating a Secret and associating the imagePullSecret to the specified Service Account

Type of Change

• feat: A new feature
• fix: A bug fix
• docs: Documentation changes
• style: Formatting, missing semi colons, etc; no code change
• refactor: Refactoring production code
• test: Adding missing tests, refactoring tests; no production code change
• chore: Updating configs, etc; no production code change

[tech2734]

Review Feedback

Nice implementation — the dockerconfigjson secret construction, SA linking via strategic-merge, and idempotency check on imagePullSecrets are all well done. A couple of items:

1. Assertion logic gap — is defined always true given empty defaults

The Assert required parameters task has this condition:

when:
  - >-
    __utility_registry_credentials_secret.resources | length == 0 or
    (utility_registry_credentials_registry_host is defined and
     utility_registry_credentials_registry_username is defined and
     utility_registry_credentials_registry_password is defined)

Since registry_host, registry_username, and registry_password all default to "" in defaults/main.yml, they will always be is defined. This means the assertion always fires — including the case where the secret already exists and the user intentionally omitted registry credentials (expecting a skip). The assertion then fails because the | length > 0 checks inside fail on the empty defaults.

The when should probably check for non-empty values (| default("", true) | length > 0) instead of just is defined, matching the pattern already used on the Create registry credentials secret task which correctly guards with:

utility_registry_credentials_registry_host | default("", true) | length > 0 and
utility_registry_credentials_registry_username | default("", true) | length > 0 and
utility_registry_credentials_registry_password | default("", true) | length > 0

2. Minor — default namespace convention

utility_registry_credentials_namespace defaults to virtualization-migration, which differs from other roles that default to openshift-mtv. May be intentional since this is a utility role not strictly tied to MTV — just flagging for awareness.

[sabre1041]

@tech2734 addressed your feedback

[tech2734]

Assertion checks fixed — looks good. Approved.