Skip to content

refactor: credential types inject env vars, orchestrator playbook - #96

Merged
sabre1041 merged 5 commits into
redhat-cop:v2from
tech2734:feature/aap-seed-update
Sep 21, 2026
Merged

sabre1041 merged 5 commits into
redhat-cop:v2from
tech2734:feature/aap-seed-update

Conversation

@tech2734

Copy link
Copy Markdown

Summary

Refactors aap_seed credential types to inject environment variables and extra vars directly, adds an orchestrator playbook, and updates downstream roles.

Changes

aap_seed

  • Custom credential types now inject VMWARE_* / K8S_AUTH_* environment variables
  • source_name / target_name are injected as extra vars by credentials (removed from survey)
  • EE organization is now optional — omitted by default for global EEs, configurable via aap_execution_environment_organization

mtv_provider / mtv_maps

  • Added VMWARE_* env var cascade with fallback to legacy mf_source_* variables
  • Updated validate tasks, templates, and argument specs

Orchestrator (vmf_orchestrate.yml)

  • New playbook: Phase 1 seeds AAP, Phase 2 launches MTV Provider jobs for each source-target pair
  • Respects aap_hosts on target clusters to scope which AAP controller handles which pairs

Files Changed

  • roles/aap_seed/defaults/main.yml, meta/argument_specs.yml, tasks/build_credentials.yml, templates
  • roles/mtv_provider/defaults/main.yml, meta/argument_specs.yml, tasks/validate.yml, templates/provider_secret.yml.j2, tasks/rescue_provider.yml
  • roles/mtv_maps/tasks/validate.yml
  • playbooks/vmf_orchestrate.yml (new)
  • inventory/inventory-sample.yml

tech2734 and others added 4 commits September 18, 2026 14:11
- New custom OCP target credential type (Migration Factory - Target
  Environment) injects K8S_AUTH_* env vars and target_name extra var
- Updated source credential type injects VMWARE_* env vars and
  source_name extra var instead of mf_source_* extra vars
- Renamed insecure_skip_tls_verify to validate_certs (inverted)
- Removed source_name/target_name from common survey spec
- Removed survey_enabled from provider/maps/plans job templates
- Added VMWARE_* env var cascade to mtv_provider role defaults
- Updated mtv_provider to use role-prefixed vars throughout
- Added orchestrator playbook (vmf_orchestrate.yml)

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- Add no_log to job_launch task (no-log-password)
- Add noqa for syntax-check[unknown-module] (ansible.controller not in CI)
- Regenerate README docs via docsible

Co-authored-by: Cursor <cursoragent@cursor.com>
@tech2734
tech2734 deployed to external-ci September 18, 2026 19:12 — with GitHub Actions Active
@tech2734
tech2734 marked this pull request as ready for review September 18, 2026 19:14
@tech2734
tech2734 requested a review from sabre1041 as a code owner September 18, 2026 19:14
Comment thread playbooks/vmf_orchestrate.yml Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>
@tech2734
tech2734 deployed to external-ci September 21, 2026 16:25 — with GitHub Actions Active
@sabre1041
sabre1041 merged commit b0c54ac into redhat-cop:v2 Sep 21, 2026
22 checks passed

This branch was successfully deployed

1 active deployment
external-ci — 38720ab0 Deployed Sep 21, 2026 by tech2734 via external-approval #651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants