feat(mtv_provider): host provider, VMCA cert, template refactor - #98
Merged
Merged
Conversation
sabre1041
requested changes
Sep 23, 2026
tech2734
force-pushed
the
feature/provider-enhancements
branch
from
September 23, 2026 12:29
805a9b8 to
8725b7b
Compare
…emplate refactor - Add create_provider_openshift.yml to ensure the host OpenShift provider exists in the target namespace before creating source providers - Rename create_provider.yml to create_provider_vmware.yml - Split templates by type: provider_vmware.yml.j2, provider_secret_vmware.yml.j2, provider_openshift.yml.j2 - Add mtv_provider_openshift_provider_name variable (default: host) - Fetch VMCA root CA certificate from vCenter /afd/vecs/ca endpoint and convert from DER to PEM for provider secret (fixes virt-v2v SSL trust issue with ESXi hosts) - Add missing variables to argument_specs: source_type, source_host, source_sdk_endpoint, source_vddk - Standardize to_json quoting across all templates - Add registry credentials job template to aap_seed - Add VDDK image to inventory sample - Regenerate role documentation Co-authored-by: Cursor <cursoragent@cursor.com>
tech2734
force-pushed
the
feature/provider-enhancements
branch
from
September 23, 2026 12:32
8725b7b to
ce8af43
Compare
Contributor
|
@tech2734 this looks really good and succeeds in my environment. Would you be able to resolve the linting errors as well as to shorten the title of the PR so that it complies with the validation rules |
tech2734
changed the title
Author
Done |
sabre1041
marked this pull request as ready for review
September 23, 2026 17:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mtv_provider_openshift_provider_name(default:host)./afd/vecs/caendpoint, converts DER→PEM, and stores it in the provider secret. This fixes thevirt-v2vSSL trust issue when connecting to ESXi hosts during migration.provider_vmware.yml.j2,provider_secret_vmware.yml.j2,provider_openshift.yml.j2). Both types now use the samelookup('template') | from_yamlcreation pattern.create_provider.yml→create_provider_vmware.yml, newcreate_provider_openshift.yml.argument_specs.yml, consistentto_jsonquoting across templates, aligned variable ordering between defaults and specs.