test: update argocd-agent self-registration test

[jparsai]

/kind enhancement

This PR is to sync e2e tests from argocd-operator to gitops-operator which were updated in #1300

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1c4d9461-f9de-4e6a-86ae-9116b81fe823

---

---

📥 Commits

Reviewing files that changed from the base of the PR and between 342fc14 and d50feca.

---

---

📒 Files selected for processing (1)

• test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go

---

---

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

---

---

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

---

---

---

📝 Summary

Summary by CodeRabbit

• Tests
  • Expanded end-to-end coverage for principal deployment settings, including self-registration defaults, enabled and disabled states, and client-certificate secret configuration.
  • Added checks that deployment environment-variable values reflect changes to self-registration and the configured secret name, including verification that updated values appear within the expected time.

📝 Summary

Walkthrough

The principal deployment environment-variable expectations now include default self-registration values. A new E2E test checks enabled settings, then checks updated values after the configuration changes.

Changes

Principal self-registration checks

Layer / File(s)	Summary
Self-registration environment checks test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go	Default expectations include disabled self-registration and an empty client-certificate secret name. The E2E test checks enabled settings, then checks updated values after the deployment reflects the new secret name.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

---

---

Merge Risk: ⚪ Minimal · up to d50fe

This change only updates end-to-end tests and does not affect production behavior. No merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the change as an update to the Argo CD agent self-registration test.
Description check	✅ Passed	The description explains that the PR syncs E2E tests from argocd-operator to gitops-operator.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

---

---

---

_{Comment @coderabbitai help to get the list of available commands.}

[jparsai]

/test v4.19-kuttl-parallel

[olivergondza]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olivergondza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [olivergondza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ranakan19]

lgtm

[jparsai]

/retest

[jparsai]

Infra issue

/test v4.19-kuttl-parallel
/test v4.19-kuttl-sequential

[jgwest]

/retest

[jparsai]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jparsai]

Rebased to get fix for e2e failure addressed by #1315

[jparsai]

/retest

[openshift-ci]

@jparsai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.19-kuttl-parallel	a7cbe67	link	true	/test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.