Skip to content

fix: Image Updater fails to start with TLS 1.3 cipher suites when cluster TLS profile uses TLS 1.2 minimum #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akhilnittala wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: Image Updater fails to start with TLS 1.3 cipher suites when cluster TLS profile uses TLS 1.2 minimum #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1719227
fix: Image Updater fails to start with TLS 1.3 cipher suites when clu…
akhilnittala Oct 4, 2026
d00fa42
fix: Image Updater fails to start with TLS 1.3 cipher suites when clu…
akhilnittala Oct 5, 2026
8b1681e
fix: Image Updater fails to start with TLS 1.3 cipher suites when clu…
akhilnittala Oct 5, 2026
45c7e10
fix: Image Updater fails to start with TLS 1.3 cipher suites when clu…
akhilnittala Oct 5, 2026
4626357
Merge branch 'master' into usr/akhil/GITOPS-11515
akhilnittala Oct 8, 2026
95fd8c3
Merge branch 'master' into usr/akhil/GITOPS-11515
akhilnittala Oct 9, 2026
b8b76e8
Merge branch 'master' into usr/akhil/GITOPS-11515
akhilnittala Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion argocd-operator/controllers/argocd/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,25 @@ func BuildTLSArgsFromClusterTLSProfile(centralTLSConfig tlsProfile.TLSConfigProf
args = append(args, "--tlsminversion", v)
}
if ciphers := argoutil.MapCipherSuites(centralTLSConfig.Ciphers); len(ciphers) > 0 {
args = append(args, "--tlsciphers", strings.Join(ciphers, ":"))
// Go does not allow configuring TLS 1.3 cipher suites.
// Only filter them when TLS versions below 1.3 are used.
if centralTLSConfig.MinVersion != "VersionTLS13" {
tls13Ciphers := map[string]bool{
"TLS_AES_128_GCM_SHA256": true,
"TLS_AES_256_GCM_SHA384": true,
"TLS_CHACHA20_POLY1305_SHA256": true,
}
filtered := make([]string, 0, len(ciphers))
for _, cipher := range ciphers {
if !tls13Ciphers[cipher] {
filtered = append(filtered, cipher)
}
}
ciphers = filtered
}
if len(ciphers) > 0 {
args = append(args, "--tlsciphers", strings.Join(ciphers, ":"))
}
}
return args
}
Expand Down
4 changes: 4 additions & 0 deletions ...ft/e2e/ginkgo/sequential/1-143_validate_deployment_Env_Args_For_Tls_Configuration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ var _ = Describe("Validate Deployment Env Args For TLS Configuration", Label("op
Spec: argov1beta1api.ArgoCDSpec{},
}
argo.Spec.ImageUpdater.Enabled = true
argo.Spec.ImageUpdater.Env = append(argo.Spec.ImageUpdater.Env, corev1.EnvVar{
Name: "ENABLE_WEBHOOK",
Value: "true",
})
Expect(c.Create(ctx, argo)).To(Succeed())
By("waiting for ArgoCD to be available")
Eventually(func() error {
Expand Down
Loading