fix(ImageUpdater): GITOPS-11648 zombie Git processes when the operator starts /manager as PID 1

[chengfang]

What does this PR do?

port the fix to https://redhat.atlassian.net/browse/GITOPS-11648 from argocd-operator #2408

PR acceptance criteria:

• Documentation was updated and verified using make serve-docs
• Unit tests were updated
• E2E tests were updated

What type of PR is this?

/kind bug

Special notes to the reviewer:

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: d1bba6a1-731b-4453-a077-edb44a2528b7

---

📥 Commits

Reviewing files that changed from the base of the PR and between 311bf78 and cc98929.

---

📒 Files selected for processing (2)

• argocd-operator/controllers/argocd/image_updater.go
• argocd-operator/controllers/argocd/image_updater_test.go

---

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

---

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

---

---

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • The Image Updater now uses its container image’s default startup command instead of overriding it. This preserves the image’s startup behavior, including running the manager under tini as the main process.

Walkthrough

The Image Updater container no longer sets /manager as its command. The deployment test now expects the container to inherit the image entrypoint.

Changes

Image Updater entrypoint

Layer / File(s)	Summary
Inherit the image entrypoint argocd-operator/controllers/argocd/image_updater.go, argocd-operator/controllers/argocd/image_updater_test.go	The container configuration leaves Command unset. The deployment test now expects this setting and notes that the image entrypoint runs the manager under tini.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: olivergondza

---

Merge Risk: ⚪ Minimal · up to cc989

The default Image Updater image supplies the expected tini-managed entrypoint, and the deployment test checks that the image entrypoint is inherited. No actionable merge-blocking risk is established.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the ImageUpdater bug, the related issue, and the PID 1 process change.
Description check		The description explains that the pull request ports the GITOPS-11648 fix and identifies it as a bug fix.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

---

• Fix all pre-merge checks with AI

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olivergondza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• argocd-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@chengfang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.19-e2e	cc98929	link	true	/test v4.19-e2e
ci/prow/v4.14-kuttl-sequential	cc98929	link	false	/test v4.14-kuttl-sequential
ci/prow/v4.19-kuttl-sequential	cc98929	link	true	/test v4.19-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.