Repository navigation
feat(prepare-sources): implement protocol-resolution module (RHIDP-15838) - #176
Open
davidfestal wants to merge 4 commits into
Open
davidfestal wants to merge 4 commits into
davidfestal wants to merge 4 commits into
Conversation
Generate manifest.json (workspace package inventory) and, when the workspace contains backstage:^ dependencies, backstage-manifest.json with @backstage package metadata extracted from yarn.lock and validated against versions.backstage.io. Add a zero-dependency Yarn Berry lockfile parser/serializer for round-trip fidelity, shared manifest types, and fixture-based tests. Extend test utilities with a mockFetch helper and wire the module into the pipeline runner. Add @vitest/coverage-v8 and ignore the coverage directory. Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com>
Intersect `plugins-list.yaml` with `rhdh-supported-packages.txt` for the current workspace, preserve packages referenced by `dist-dynamic/embedded/*/package.json`, remove infrastructure directories (`packages/app`, `packages/backend`, `.storybook`, `examples/`, `node_modules`), and delete remaining non-supported plugin directories. Rewrite the filtered `plugins-list.yaml` back to the overlay path, preserving full lines including export CLI args. Expose `overlayRepoRoot` on `PipelineInputs` so tier-list files can be read from the overlay repository root instead of resolving `../..` inside the module. Update the fixture loader to support an `input/overlay-root/` directory for tier-list fixtures. Add the module implementation, unit tests, fixtures, and README.md; wire the module into the pipeline runner. Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: David Festal <dfestal@redhat.com>
…ne module Remove test, mock, and dev-only files from surviving workspace packages: directories `dev/`, `e2e-tests/`, `__tests__/`, `__mocks__/` and files matching `*.test.ts`, `*.test.tsx`, `*.spec.ts`, `*.spec.tsx`, while preserving paths under `node_modules/` and `dist-dynamic/`. Aligns with `sync-midstream.sh` lines 917–924. Add the module implementation, fixture-based tests, fixtures, and README.md; wire the module into the pipeline runner. Exclude `__fixtures__` directories from Vitest discovery in `vite.config.ts`. Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com>
… pipeline module Resolve `workspace:^` and `backstage:^` protocol references to concrete npm semver ranges in `package.json` and `yarn.lock`. Preserve `workspace:^` for packages that still exist locally on disk, and create `packages/type-shims` when surviving code needs types from scrubbed packages. Add shared `yarn-lock-helpers` for mutating parsed Yarn Berry lockfiles, consumed by `protocol-resolution` and future modules. Add the module implementation, fixture-based tests, fixtures, and README.md; wire the module into the pipeline runner. Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(prepare-sources): implement
protocol-resolutionpipeline moduleResolves RHIDP-15838
Summary
Adds the
protocol-resolutionmodule to theprepare-sourcespipeline. This module rewritesworkspace:^,workspace:*,workspace:~, andbackstage:^protocol references inpackage.jsonandyarn.lockinto concrete npm semver ranges, and creates@internal/type-shimswhen scrubbed host-app types are needed by surviving code.This is a full TypeScript rewrite of the legacy
update-workspace.js --update+createTypeShimsPackagelogic, using a parser-based (structuredLockfile/LockfileBlock) approach instead of regex-based string manipulation.What's included
Core module (
lib/modules/protocol-resolution/)package-json.ts— resolves protocol refs across all five dep sections +resolutionsyarn-lock-update.ts— multi-pass lockfile orchestrator: delete stale blocks → convert protocol dep values → create missing npm resolution blocks → resolve dangling deps → enrich specifiersyarn-lock-blocks.ts— creates hard npm resolution blocks (for both scrubbed and local packages)yarn-lock-enrich.ts— adds missing specifiers to existing block keysyarn-lock-metadata.ts— manifest + npm-registry metadata resolution for block creationtype-shims.ts— full type-shims package with asset-type detection, theme augmentation,EXTRA_RUNTIME_TYPES, and tsconfig wiringsemver-range.ts,version-map.ts,utils.ts,constants.ts— shared helpersBehavioral alignment with legacy
d405bc257("Additional version drift fixes")createCombinedKeysForLocalPackagesapproach that attached npm keys to soft blocks)Test coverage — 24 declarative input/output fixtures covering:
workspace:^,workspace:*,workspace:~,backstage:^)resolutionssection,workspaces: { packages: [...] }object formatEXTRA_RUNTIME_TYPES, npm fallbackNOTE: Based on top of PR #175 which should be merged first