Repository navigation
Conversation
Fail incomplete dist-dynamic exports and empty io.backstage.dynamic-packages images into failed-exports so overlay publish does not push garbage to ghcr. Co-authored-by: Cursor <cursoragent@cursor.com>
Frontend scalprum exports use dist/remoteEntry.js, not backend index.cjs.js. Verified locally against community-plugins bookmarks via export-dynamic.sh. Co-authored-by: Cursor <cursoragent@cursor.com>
Stop swallowing export-dynamic.sh exit codes with || true so export-only runs cannot succeed when dist-dynamic/OCI payload validation fails. Keep detailed failed-exports reporting via always() in the workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
|
nickboldt
reviewed
Oct 9, 2026
| mkdir -pv "${packDestination}" | ||
|
|
||
| # Gate 1 again for archive-only clarity (already passed above after export) | ||
| if ! assert_dist_dynamic_payload "$(pwd)/dist-dynamic"; then |
Member
There was a problem hiding this comment.
do we expect that dist-dynamic will be empty at this point or is the AI hallucinating here?
nickboldt
reviewed
Oct 9, 2026
| fi | ||
| fi | ||
|
|
||
| if command -v skopeo >/dev/null 2>&1 && skopeo inspect "oci-archive:${archive}" >/dev/null 2>&1; then |
Member
There was a problem hiding this comment.
performance issue: you're inspecting the same container twice, and you're not using --no-tags either time.
rewrite so you only call skopeo inspect --no-tags once and then use the result of that, if positive, with jq & sed
nickboldt
reviewed
Oct 9, 2026
| return 1 | ||
| fi | ||
| mkdir -p "${tmpdir}/layer" | ||
| if ! tar xzf "$blob" -C "${tmpdir}/layer" 2>/dev/null && ! tar xf "$blob" -C "${tmpdir}/layer" 2>/dev/null; then |
Member
There was a problem hiding this comment.
do we anticipate needing both zipped and non-zipped artifacts here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-plugin-payload.shwith (dist-dynamicpackage + entry) and (non-emptyio.backstage.dynamic-packages, with layerindex.jsonfallback).export-dynamic.shso hollow exports land infailed-exportsand are not pushed to ghcr / listed inpublished-exports.Test plan
bash export-dynamic/validate-plugin-payload.test.sh(unit + local podman Gate 2 smoke)Test validate-plugin-payloadworkflow green on this PR/publishand one intentionally broken export; confirmfailed-exportsblocks pushMade with Cursor