fix(language-support): support generic records - #4412
Conversation
Signed-off-by: Miroma <its.miroma@proton.me>
f6f159f to
50b1937
Compare
Signed-off-by: Miroma <its.miroma@proton.me>
Signed-off-by: Miroma <its.miroma@proton.me>
|
LGTM, better to add a unit test case |
|
Hello @wenytang-ms, I just got back to this! I don't see any tests for the tmLanguage in the repo yet, do you know where I can find them? |
datho7561
left a comment
There was a problem hiding this comment.
Looks good; improves the syntax highlighting for this case before the semantic tokens kick in. There's no need for unit tests; I don't think there's a good way to do that and we haven't been from what I understand.
Thanks, Miroma!
|
Thank you for merging!
There are definitely ways to add tests for a tmLanguage, which might be interesting to explore: For example, by using the |
Notice line 14: