Skip to content

Add eatmem_free_memory to argument list - #70

Open
malucius-rh wants to merge 1 commit into
masterfrom
enable_eatmem_free_memory
Open

Add eatmem_free_memory to argument list#70
malucius-rh wants to merge 1 commit into
masterfrom
enable_eatmem_free_memory

Conversation

@malucius-rh

Copy link
Copy Markdown
Contributor

Description

This enables the --eatmem_free_memory option, which was implemented in the original drop but never added to ARGUMENT_LIST

Before/After Comparison

Before: trying to use --eatmem_free_memory would result in a failed run because the option wasn't considered legitmate
After: the option passes validation and affects the run

Clerical Stuff

This closes #65
Relates to JIRA: RPOPC-1044
Artifacts:
PCP traces of mem.util.avail using default value
availmem_default.txt
PCP traces of mem.util.avail using --eatmem_free_memory 300000
availmem_efm300G.txt

@malucius-rh
malucius-rh requested a review from dvalinrh August 10, 2026 15:34
@malucius-rh malucius-rh self-assigned this Aug 10, 2026
@malucius-rh malucius-rh added the bug Something isn't working label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e7071f29-7b2e-4fd5-895f-f4fe56fcecd5

📥 Commits

Reviewing files that changed from the base of the PR and between b1b40a0 and 7e5abb0.

📒 Files selected for processing (1)
  • iozone/iozone_run.sh

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added support for configuring the eatmem_free_memory option when running the benchmark script.

Walkthrough

The change adds eatmem_free_memory to the accepted getopt arguments in iozone_run.sh, so the flag is parsed instead of ignored.

Changes

iozone option parsing

Layer / File(s) Summary
Register eatmem_free_memory
iozone/iozone_run.sh
The getopt argument list now accepts eatmem_free_memory with a value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dvalinrh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding eatmem_free_memory to the argument list.
Description check ✅ Passed The description includes the required summary, before/after behavior, issue closure, JIRA reference, and supporting artifacts.
Linked Issues check ✅ Passed The change adds eatmem_free_memory to ARGUMENT_LIST, addressing issue #65 and enabling the specified value to be used.
Out of Scope Changes check ✅ Passed The one-line change is directly related to the linked issue and stated pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: --eatmem_free_memory flag is silently ignored

1 participant