Switch wget of iozone tarball from http to https - #71
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe iozone runner now downloads the source kit over HTTPS. Its failure message uses the same HTTPS URL. Changesiozone download security
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@iozone/iozone_run.sh`:
- Around line 454-456: Update the documented iozone source URL in README.md to
use https://www.iozone.org/src/current/ instead of the plain HTTP URL, matching
the HTTPS URL already used by the wget command in iozone_run.sh.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ca116689-eb20-4b3b-956f-9b3615ec86fe
📒 Files selected for processing (1)
iozone/iozone_run.sh
| wget https://www.iozone.org/src/current/${iozone_kit}.tar | ||
| if [ $? -ne 0 ]; then | ||
| exit_out "wget http://www.iozone.org/src/current/${iozone_kit}.tar failed" 1 | ||
| exit_out "wget https://www.iozone.org/src/current/${iozone_kit}.tar failed" 1 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Update the documented source URL to HTTPS.
README.md:150-156 still directs users to http://www.iozone.org/src/current/. Users who follow the documentation can still download the source over plain HTTP. Change that URL to HTTPS in the same PR.
As per path instructions, this review prioritizes major security issues and avoids nitpicks.
🧰 Tools
🪛 Shellcheck (0.11.0)
[info] 454-454: Double quote to prevent globbing and word splitting.
(SC2086)
[style] 455-455: Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
(SC2181)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@iozone/iozone_run.sh` around lines 454 - 456, Update the documented iozone
source URL in README.md to use https://www.iozone.org/src/current/ instead of
the plain HTTP URL, matching the HTTPS URL already used by the wget command in
iozone_run.sh.
Source: Path instructions
1 participant
Description
This changes the wget of the iozone tarball from developer's site from http to https in accordance with qodo recommendation during doc updates
Before/After Comparison
Before: iozone tarball is wgetted using http
After: iozone tarball is wgetted using https
Clerical Stuff
This closes #66
Relates to JIRA: RPOPC-1045
Comms to open.spec.org before:
get_iozone_http_csv.csv
Comms to open.spec.org after:
get_iozone_https_csv.csv