Keep the workbench off /develop/ - #3915
Merged
Merged
Conversation
The Redis CLI on /develop/ is a picture of one: a block of commands and their output, there to show what Redis looks like. The workbench mounts anyway, because the page has a terminal in it, and puts a docked console along the bottom of a landing page that never asked for one. A page can now say no, the way a command page says yes: window.REDIS_WORKBENCH_NEVER, set by the template. Hugo knows which page this is; the browser only knows a path that is prefixed differently in every environment. It declines outright rather than opening closed — nothing mounts, so there is no bar, no session and no keyspace probing from this page. A "Try it" added here later still works: RedisWorkbench.open() reports that it cannot run and the caller opens redis.io/cli, as it did before the dock existed. Only /develop/ itself. Its children use the same layout and are ordinary docs pages, examples and all. Verified locally: no dock on /develop/ even with one left open in localStorage, and nothing from the dock reaches the backend; the dock is still there on /develop/data-types/hashes/ under the same layout and on /commands/hset/. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at eab6b84 |
|
|
andy-stark-redis
approved these changes
Sep 3, 2026
andy-stark-redis
left a comment
andy-stark-redis
left a comment
Contributor
There was a problem hiding this comment.
Works fine (and Workbench still appears on other pages where it should). Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change hides the workbench on the /develop/ landing page