Repository navigation
release: ship redrob-code.png as the launcher icon - #119
Merged
Merged
Conversation
Redrob Launcher 0.5.0 reads an optional `icon` in redrob-launcher.json: a square PNG asset of the same release, shown in its catalog instead of the built-in icon. The assets job now copies packages/identity/mark-512x512.png beside the launcher assets as redrob-code.png, the manifest written by launcher-assets.ts carries `"icon": "redrob-code.png"` (ICON_NAME), and the shared publish job is told `launcher_icon: redrob-code.png` so the copy it writes over every asset says the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
redrob-code.png(frompackages/identity/mark-512x512.png), and passeslauncher_icon: redrob-code.pngto the shared publish job (redrob-labs/.github#14), which copies it beside the installers, lists it inSHA256SUMS.txtand writesredrob-launcher.jsonas{ "schema": 1, "sharedAccount": true, "icon": "redrob-code.png" }.Why
Redrob Launcher 0.5.0 reads
iconfrom the manifest and shows that PNG in its catalog, so the launcher's logo for this product follows the product's own releases.Takes effect at the next release. Depends on redrob-labs/.github#14 being merged first: a reusable workflow rejects an input it does not declare.