GH-18: add override for agents store location - #19
Merged
Merged
Conversation
Fix five findings from the adversarial GH-18 review: - init_knowledge: verify the fallback ref's canonical path before binding, so a same-named sibling in another root or an org ref cannot hijack the write into the wrong store slot (tools/init.go, projects.CanonicalPath) - resolver: skip .index children in store mode at discovery and in dynamic resolution so a project slot can never live inside the removable index directory (projects/resolver.go) - resolver: suppress the in-tree ignore warning when the store slot IS the in-tree dir for explicit projects or org roots placed inside the store - tests: store-mode fallback binding, .index skip, slot warning suppression, and _global write/update/list under --store regression guard - README: document the central store's single-writer constraint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.