Skip to content

ci(bind): list ports commits in candidate PR #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryanwieg merged 1 commit into from
Aug 28, 2026
Merged

ci(bind): list ports commits in candidate PR #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/ci/ci-tests/test_bind920_candidate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,14 @@ def test_candidate_workflow_never_publishes_packages(self) -> None:
self.assertNotIn("release_channel.py publish", workflow)
self.assertIn("Publication: not performed by this workflow", workflow)

def test_candidate_workflow_includes_ports_commit_subjects_in_pr_body(self) -> None:
"""Review PRs must show the FreeBSD Ports commits behind the candidate."""
workflow = self.workflow_text()
self.assertIn("### FreeBSD Ports Changes", workflow)
self.assertIn("while read -r commit subject; do", workflow)
self.assertIn("printf -- '- `%s` %s\\n' \"$commit\" \"$subject\"", workflow)
self.assertIn("No dns/bind920 commits found between the pinned and candidate Ports commits.", workflow)

def test_candidate_workflow_uses_pinned_actions(self) -> None:
"""Workflow actions must stay pinned to immutable SHAs."""
workflow = self.workflow_text()
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/bind920-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,16 @@ jobs:
--output "$RUNNER_TEMP/assessment.md"
{
cat "$RUNNER_TEMP/assessment.md"
printf '\n### FreeBSD Ports Changes\n\n'
if [ -s "$PORTS_LOG" ]; then
while read -r commit subject; do
if [ -n "$commit" ]; then
printf -- '- `%s` %s\n' "$commit" "$subject"
fi
done < "$PORTS_LOG"
else
printf -- '- No dns/bind920 commits found between the pinned and candidate Ports commits.\n'
fi
printf '\n### Candidate Inputs\n\n'
printf -- '- FreeBSD Ports commit: `%s`\n' "$CANDIDATE_COMMIT"
printf -- '- Previous FreeBSD Ports commit: `%s`\n' '${{ steps.ports.outputs.current_commit }}'
Expand Down
Loading