fix(client): update OpenCode E2E execution calls - #1972
Conversation
NathanFlurry
commented
Sep 10, 2026
- Update OpenCode E2E execution calls to the current client API.
- Handle optional execution exit codes and captured output in assertions.
Co · session: Fix agentos main CI (clippy 1.98 + browserbase types)
|
| .to_string(), | ||
| ], | ||
| ExecOptions::default(), | ||
| LanguageExecutionOptions::default(), |
There was a problem hiding this comment.
🟠 Medium · Capture probe output before asserting on it
LanguageExecutionOptions::default() sets output.capture to OutputCapture::None. The language-execution client sends that mode to the sidecar, which therefore completes with stdout: None and stderr: None; unwrap_or_default() then makes the JSON assertions search an empty byte slice, so this E2E test deterministically fails even when the Node probe succeeds.
Set the probe's output capture to All (and do the same for the diagnostic log commands if their output is meant to appear in the panic) before calling exec_argv.
There was a problem hiding this comment.
Fixed in fab45d8. The probe and both diagnostic log commands now use OutputCapture::All, so their stdout and stderr are available for assertions and panic diagnostics. cargo check -p agentos-client --test opencode_session_e2e passes.