Skip to content

fix(client): update OpenCode E2E execution calls - #1972

Open
NathanFlurry wants to merge 3 commits into
fix/large-enum-variant-clientfrom
fix/opencode-session-e2e-client-api
Open

fix(client): update OpenCode E2E execution calls#1972
NathanFlurry wants to merge 3 commits into
fix/large-enum-variant-clientfrom
fix/opencode-session-e2e-client-api

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member
  • Update OpenCode E2E execution calls to the current client API.
  • Handle optional execution exit codes and captured output in assertions.

@the-company-company

Copy link
Copy Markdown

Co · session: Fix agentos main CI (clippy 1.98 + browserbase types)

  • Auto-fix ; feedback on this pull request flows to the session and gets addressed
  • Review ; Co reviews new pushes

@co <ask> hands Co a task · @co mute pauses · @co archive ends the session

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 1 medium-severity finding

Reviewed commit 6630717.

.to_string(),
],
ExecOptions::default(),
LanguageExecutionOptions::default(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium · Capture probe output before asserting on it

LanguageExecutionOptions::default() sets output.capture to OutputCapture::None. The language-execution client sends that mode to the sidecar, which therefore completes with stdout: None and stderr: None; unwrap_or_default() then makes the JSON assertions search an empty byte slice, so this E2E test deterministically fails even when the Node probe succeeds.

Set the probe's output capture to All (and do the same for the diagnostic log commands if their output is meant to appear in the panic) before calling exec_argv.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in fab45d8. The probe and both diagnostic log commands now use OutputCapture::All, so their stdout and stderr are available for assertions and panic diagnostics. cargo check -p agentos-client --test opencode_session_e2e passes.

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found

Reviewed commit fab45d8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant