Repository navigation
Keep Unix line endings in bots and reject Windows ones - #10
Merged
Merged
Conversation
The repository stores every file with Unix line endings, and a launcher script with Windows line endings cannot run under sh; the failure used to show up only in the moderation run as a message about a stray character. A .gitattributes file makes Git store and check out Unix line endings on every system. The validator now rejects any file of a bot that has Windows line endings (CRLF) and names the file. No stored file changes: all 200 text files already have Unix line endings. Two test helpers wrote text, which gives Windows line endings on Windows; they now write bytes.
Contributor
|
@robocode-dev/rumble-moderators Moderation needs your decision for The required check stays pending. After reviewing, use |
Contributor
Author
|
/moderation approve Unix line endings: Git setting and validator rule, tests pass |
Contributor
|
@flemming-n-larsen accepted the escalated moderation for Merge remains a human action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Every file in this repository is stored with Unix line endings (LF). A launcher script with Windows line endings (CRLF) cannot run under
sh, and until now the failure appeared only in the moderation run, as a message about a stray character..gitattributesfile makes Git store and check out Unix line endings on every system.Orbit.sh has Windows line endings (CRLF); convert it to Unix line endings (LF). Binary files and__pycache__are not checked.CONTRIBUTING.mdandtemplates/README.mdtell authors to use Unix line endings.Checks
This is not a bot submission. It is a change to the validator and repository settings, so it needs a moderator's review and merge.