Repository navigation
Make the App logins used by catalog verification configurable - #5
Merged
Merged
Conversation
Contributor
|
@robocode-dev/rumble-moderators Moderation needs your decision for The required check stays pending. After reviewing, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog verification compared the catalog pull request's author with the live publisher App, so the test publisher App was rejected ("Not a publisher-created catalog PR on main"). The App names now come from the repository variables
RUMBLE_MODERATOR_LOGINandRUMBLE_PUBLISHER_LOGIN, which are set in this test repository to the test Apps, and fall back to the live Apps when unset. The same change is open inrumble-botsso both repositories run identical files.