Skip to content

Harden ranked synchronization boundaries - #3

Merged
flemming-n-larsen merged 1 commit into
mainfrom
fix/pr-2-review
Aug 4, 2026
Merged

Harden ranked synchronization boundaries#3
flemming-n-larsen merged 1 commit into
mainfrom
fix/pr-2-review

Conversation

@flemming-n-larsen

Copy link
Copy Markdown
Contributor

Review findings fixed

  • allow practice configuration without a registered clientId, while ranked mode still fails before repository access when identity is absent
  • reject repository and contract URLs carrying query strings or fragments so credentials cannot leak through clone arguments or diagnostics
  • reject catalog bot paths that are absolute, non-bots/, empty-segmented, or traversal-bearing
  • keep every test at exactly one Cliewen purpose tag

Verification

  • ./gradlew clean build --rerun-tasks
  • live read-only sync against robocode-dev/rumble-data revision e24fe58032cd6b119542ddd74d2f4423ba8d279a

Follow-up audit and fix for merged PR #2.

@flemming-n-larsen
flemming-n-larsen merged commit 20c1997 into main Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant